fix: [build] can`t find qdbus in low version#235
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom Jan 6, 2026
Merged
fix: [build] can`t find qdbus in low version#235deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
Conversation
Log: as title
deepin pr auto review我来对这个CMakeLists.txt的差异进行审查:
改进建议:
if(QT_DESIRED_VERSION VERSION_LESS 6)这样比使用正则匹配更直观和准确。
if(QT_DESIRED_VERSION VERSION_LESS 6)
find_package(Qt5DBus REQUIRED)
find_package(Qt5PrintSupport QUIET)
if(Qt5PrintSupport_FOUND)
list(APPEND LINK_LIBS Qt5::PrintSupport)
endif()
list(APPEND LINK_LIBS Qt5::DBus)
endif()
这些改进建议主要是为了提高代码的可维护性和可读性,而不是修复任何实际的问题。当前的实现已经相当不错了。 |
lzwind
approved these changes
Jan 6, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LiHua000, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: as title